Skip to content

476 - 20200602 type hints part3 #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

hjmjohnson
Copy link
Contributor

Related to #476 .

Description

Next set of changes related to clean typehinting.

Status

Ready

Types of changes

  • Docstrings/Documentation updated

@hjmjohnson hjmjohnson changed the title 20200602 type hints part3 476 - 20200602 type hints part3 Jun 3, 2020
@hjmjohnson
Copy link
Contributor Author

@wyli Ready to go.

@wyli
Copy link
Contributor

wyli commented Jun 3, 2020

@wyli Ready to go.

it probably passes your tests locally with your specific environment, but currently I couldn't verify the correctness...

I think we need to fix and merge #483 before merging the rest of the relevant PRs. so, could you please help with 483 when you have time?

@hjmjohnson
Copy link
Contributor Author

#483 is going to require all of the items of #473 before it will pass. That is why I have been working all day to break apart #473 into into smaller pull requests. The individual pull requests will be a nightmare to make pass pytype individually.

We spent almost a week identifying and addressing what needs to be done to get pytype, mypy, and flake8 to pass initial type hinting checks.

@wyli
Copy link
Contributor

wyli commented Jun 3, 2020

#483 is going to require all of the items of #473 before it will pass. That is why I have been working all day to break apart #473 into into smaller pull requests. The individual pull requests will be a nightmare to make pass pytype individually.

We spent almost a week identifying and addressing what needs to be done to get pytype, mypy, and flake8 to pass initial type hinting checks.

thanks, since this is a significant new feature, would be great to document your efforts in ticket #476, so that we know what the plan is and where we are...

@hjmjohnson
Copy link
Contributor Author

thanks, since this is a significant new feature, would be great to document your efforts in ticket #476, so that we know what the plan is and where we are...

Done.

@wyli wyli mentioned this pull request Jun 3, 2020
11 tasks
@hjmjohnson hjmjohnson force-pushed the 20200602-type-hints_part3 branch from 0a266cb to eecbd60 Compare June 4, 2020 14:27
@hjmjohnson
Copy link
Contributor Author

No progress too much work to maintain.

@hjmjohnson hjmjohnson closed this Jun 5, 2020
@hjmjohnson hjmjohnson deleted the 20200602-type-hints_part3 branch June 5, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants